Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT License in standalone.js #1482

Closed
marclave opened this issue Apr 22, 2024 Discussed in #1335 · 4 comments
Closed

MIT License in standalone.js #1482

marclave opened this issue Apr 22, 2024 Discussed in #1335 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@marclave
Copy link
Member

Discussed in #1335

Originally posted by Alvie March 28, 2024
Hi!

I want to use this but I am a little confused about the MIT Licensing. From what I understand, is that I need to include the copyright notice and the license with the "software", but I am retrieving it with NPM and only exposing the standalone.js

I am not too familiar with how licenses work, I want to include the copyright notice and the license info, but do I need to do this separately. Perhaps it should be included in the standalone.js instead?
https://github.com/scalar/scalar/discussions?discussions_q=MIT+License+in+standalone.js%3F
Sorry if this is a very nooby question 😅

@marclave marclave changed the title MIT License in standalone.js? MIT License in standalone.js Apr 22, 2024
@hanspagel hanspagel self-assigned this Apr 22, 2024
@Alvie
Copy link

Alvie commented Apr 23, 2024

Thanks for creating this issue! I'll be sure to update my @scalar/api-reference once it is done

@hanspagel
Copy link
Member

You’re right, this wasn’t very clear. MIT is basically the "do whatever you want" license, so people do with the code whatever they want. But looking at the license it totally makes sense to expect it to be part of the output. What we did is to add a tiny header with a link to the LICENSE:

https://github.com/scalar/scalar/blob/404227c5f409356fdf9388be42b53df7789e19d2/packages/api-reference/license-banner.txt

Not released yet, but we’ll probably release it later this day. What do you think? Does this help?

@hanspagel hanspagel added the enhancement New feature or request label Apr 24, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@hanspagel
Copy link
Member

Oops, that automation wasn’t helpful.

@hanspagel hanspagel reopened this Apr 24, 2024
@Alvie
Copy link

Alvie commented Apr 24, 2024

You’re right, this wasn’t very clear. MIT is basically the "do whatever you want" license, so people do with the code whatever they want. But looking at the license it totally makes sense to expect it to be part of the output. What we did is to add a tiny header with a link to the LICENSE:

https://github.com/scalar/scalar/blob/404227c5f409356fdf9388be42b53df7789e19d2/packages/api-reference/license-banner.txt

Not released yet, but we’ll probably release it later this day. What do you think? Does this help?

Thanks, I think it looks good :) I guess this is more up to you how you want to apply it. I think you might want to add a copyright notice, examples:

Copyright 2023-2024 Scalar (https://github.com/scalar/scalar/graphs/contributors)
Copyright: Scalar
(c) Scalar and other contributors

Look at how bootstrap does it and explains it:
https://getbootstrap.com/docs/4.1/about/license/
#1335 (comment)

Or jQuery

/*! jQuery v3.7.1 -ajax,-ajax/jsonp,-ajax/load,-ajax/script,-ajax/var/location,-ajax/var/nonce,-ajax/var/rquery,-ajax/xhr,-manipulation/_evalUrl,-deprecated/ajax-event-alias,-effects,-effects/animatedSelector,-effects/Tween | (c) OpenJS Foundation and other contributors | jquery.org/license */

https://code.jquery.com/jquery-3.7.1.slim.min.js

But I'm not an expert on this matter, it's more of a legal thing I guess, and it's up to you how to enforce it. I just didn't want to fall foul of the rules by accident 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants