Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support to check Java's @Override annotation (OverrideJavaChecker) #214

Closed
HyukjinKwon opened this issue Aug 4, 2016 · 7 comments
Labels

Comments

@HyukjinKwon
Copy link

I see Java's @Deprecated can be checked with DeprecatedJavaChecker but it might be nicer if we have a rule for preventing @Override as well.

@matthewfarwell
Copy link
Member

Good idea. Do you want to do the PR?

@HyukjinKwon
Copy link
Author

I am afraid I am not used to the code base here. Is it okay to give a shot though referring DeprecatedJavaChecker?

@canoztokmak
Copy link
Contributor

@HyukjinKwon yes, I guess it will be quite similar to DeprecatedJavaChecker implementation.

@canoztokmak
Copy link
Contributor

submitted #245 for this issue.

@HyukjinKwon
Copy link
Author

Thank you.

@matthewfarwell
Copy link
Member

#245 has been merged. Closing.

@HyukjinKwon
Copy link
Author

Thanks for dealing with this @canoztokmak and @matthewfarwell. I am eager to try this in a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants