Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageNamesChecker default regex allows uppercase #310

Closed
anilkumarmyla opened this issue May 7, 2018 · 3 comments
Closed

PackageNamesChecker default regex allows uppercase #310

anilkumarmyla opened this issue May 7, 2018 · 3 comments
Labels

Comments

@anilkumarmyla
Copy link

anilkumarmyla commented May 7, 2018

As per scala/java naming conventions, package names are written in all lower case. But the default regex and documentation point to a regex that allows camelcase package names

class PackageNamesChecker extends ScalariformChecker {
val DefaultRegex = "^[a-z][A-Za-z]*$"
@matthewfarwell
Copy link
Member

Thanks. Do you want to do a PR for this?

@anilkumarmyla
Copy link
Author

I'll give it a try!

@mwz
Copy link

mwz commented Mar 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants