Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing build for Scala 3 + Scala.JS #1982

Closed
japgolly opened this issue Mar 22, 2021 · 5 comments
Closed

Missing build for Scala 3 + Scala.JS #1982

japgolly opened this issue Mar 22, 2021 · 5 comments

Comments

@japgolly
Copy link

Hellooooooo! I can see that Scalatest is published for Scala.JS and for Scala 3.0 separately, but is missing a build for Scala 3.0 and Scala.JS together (suffix should be sjs1_3.0.0-RC1).

> curl -s https://repo1.maven.org/maven2/org/scalatest/ | fgrep scalatest_ | fgrep sjs1_
<a href="scalatest_sjs1_2.11/" title="scalatest_sjs1_2.11/">scalatest_sjs1_2.11/</a>                                             -         -      
<a href="scalatest_sjs1_2.12/" title="scalatest_sjs1_2.12/">scalatest_sjs1_2.12/</a>                                             -         -      
<a href="scalatest_sjs1_2.13/" title="scalatest_sjs1_2.13/">scalatest_sjs1_2.13/</a>                                             -         -      


> curl -s https://repo1.maven.org/maven2/org/scalatest/ | fgrep scalatest_ | fgrep 3.0.0
<a href="scalatest_3.0.0-M1/" title="scalatest_3.0.0-M1/">scalatest_3.0.0-M1/</a>                                              -         -      
<a href="scalatest_3.0.0-M2/" title="scalatest_3.0.0-M2/">scalatest_3.0.0-M2/</a>                                              -         -      
<a href="scalatest_3.0.0-M3/" title="scalatest_3.0.0-M3/">scalatest_3.0.0-M3/</a>                                              -         -      
<a href="scalatest_3.0.0-RC1/" title="scalatest_3.0.0-RC1/">scalatest_3.0.0-RC1/</a>                                             -         -      
@japgolly japgolly changed the title Build for Scala 3 with Scala.JS missing Missing build for Scala 3 + Scala.JS Mar 22, 2021
@cheeseng
Copy link
Contributor

@japgolly We were blocked by the following issue in our first attempt:

#1918 (comment)

I just tried it again with the latest 3.0.0-RC1 and the problem seems fixed now, I'll continue with other modules and see if I can build them all and run test. Hopefully if everything goes fine we may release for Scala 3 + Scala JS.

Cheers.

@cheeseng
Copy link
Contributor

@japgolly Fyi PR submitted:

#1985

@japgolly
Copy link
Author

Oh wow, that's a very significant amount of work! Thanks so much @cheeseng !

@cheeseng
Copy link
Contributor

cheeseng commented Apr 1, 2021

@japgolly Fyi this is released as part of 3.2.7 already.

Cheers.

@japgolly
Copy link
Author

japgolly commented Apr 5, 2021

Fantastic news, thanks again @cheeseng !!

@japgolly japgolly closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants