Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation case study: Transforming data begins with Either rather than Validated #153

Closed
mmynsted opened this issue May 30, 2019 · 5 comments
Assignees

Comments

@mmynsted
Copy link

In the Validation Case Study, the Transforming data section begins with a description of how there are not enough types to actually perform a transformation. This makes sense but Either is used in the examples here. Just before this section was a the addition of the or combinator, and before that was converting from using Either to using Validated.

Example from the Transforming data section:

To implement map we need to change the definition of Check.
Specifically, we need to a new type variable
to separate the input type from the output:

type Check[E, A, B] = A => Either[E, B]

Then later in the Predicates section Validated is again used.

I propose that Validated be used throughout this document, rather than Either.

@mmynsted
Copy link
Author

I can't assign it to myself so If you agree with this issue please assign it to me.

@davegurnell
Copy link
Contributor

Thanks for looking at this @mmynsted. I think in the medium term we need to rewrite this and parts of the monads/applicatives chapters to use Parallel.

@mmynsted
Copy link
Author

mmynsted commented Jun 1, 2019

Ah yes. I see your issue here #103.

@mmynsted
Copy link
Author

mmynsted commented Jul 3, 2019

Sigh. I have no idea what I thought needed to be changed here. Could this one be closed?
Perhaps time would be better spent on #103.

@mmynsted mmynsted closed this as completed Jul 3, 2019
@davegurnell
Copy link
Contributor

No worries -- thanks for closing.

👍 to #103. Some day I'll get time... some day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants