Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unapply matchers #1948

Open
edmundnoble opened this issue Aug 9, 2018 · 1 comment
Open

Unapply matchers #1948

edmundnoble opened this issue Aug 9, 2018 · 1 comment
Labels
scalaz8

Comments

@edmundnoble
Copy link
Contributor

We should remove every unapply matcher, because they ruin what little exhaustivity checking we have.
@edmundnoble
Copy link
Contributor Author

Instead of fixing this the way I presented, @alexknvl how about adding "match totality" annotations on "sealed matches", and checking them inside scalaz-plugin? Is that feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scalaz8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edmundnoble