Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on play-guice #37

Open
berryware opened this issue Sep 6, 2018 · 0 comments
Open

Remove dependency on play-guice #37

berryware opened this issue Sep 6, 2018 · 0 comments

Comments

@berryware
Copy link

scaldi-play currently requires that the guice module be loaded to use it. This never felt right to me. It appears to be required because of a reference to com.google.inject.CreationException. In looking at the catch block, there is no need for this reference.

I propose that the catch block in ScaldiBuilder.scala be changed to

    } catch {
      case p: PlayException => throw p
      case t: Throwable => t.getCause match {
        case pe: PlayException => throw pe
        case _ => throw t
      }
    }

I will submit a pull request for the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant