You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
scaldi-play currently requires that the guice module be loaded to use it. This never felt right to me. It appears to be required because of a reference to com.google.inject.CreationException. In looking at the catch block, there is no need for this reference.
I propose that the catch block in ScaldiBuilder.scala be changed to
} catch {
case p: PlayException => throw p
case t: Throwable => t.getCause match {
case pe: PlayException => throw pe
case _ => throw t
}
}
I will submit a pull request for the above
The text was updated successfully, but these errors were encountered:
scaldi-play currently requires that the guice module be loaded to use it. This never felt right to me. It appears to be required because of a reference to com.google.inject.CreationException. In looking at the catch block, there is no need for this reference.
I propose that the catch block in ScaldiBuilder.scala be changed to
I will submit a pull request for the above
The text was updated successfully, but these errors were encountered: