Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename optIntoASA to optInToASA #710

Closed
kashishkhullar opened this issue Jun 9, 2022 · 2 comments
Closed

Rename optIntoASA to optInToASA #710

kashishkhullar opened this issue Jun 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kashishkhullar
Copy link

kashishkhullar commented Jun 9, 2022 •
edited
Loading

Describe the bug

The function names are not maintained properly. For instance optIntoASA has "t" where as optInToApp has "T". To avoid confusion and consistency I suggest that we should only have optIntoASA and optInToASA where "t" is used.

Possible Solution

Rename all references of optIntoASA -> optInToASA
@kashishkhullar kashishkhullar added the bug Something isn't working label Jun 9, 2022
@kashishkhullar kashishkhullar changed the title Rename optInToApp to optIntoApp Rename optIntoASA to optInToASA Jun 9, 2022
@vuvoth
Copy link
Contributor

vuvoth commented Jun 13, 2022

Thanks @kashishkhullar!

@sczembor
Copy link
Contributor

Thanks for reporting the issue. It was taken care of here #714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robert-zaremba @kashishkhullar @sczembor @vuvoth