Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Type #268

Closed
CronosUnder opened this issue Oct 14, 2022 · 2 comments
Closed

Button Type #268

CronosUnder opened this issue Oct 14, 2022 · 2 comments
Labels
Released The issue is fixed/considered and released

Comments

@CronosUnder
Copy link

the button type can be added to the buttons, since when pressing them and being inside a form, they launch the submit event,

context:
react, formik

@jgab-net
Copy link

jgab-net commented Oct 23, 2022

the solution for the button is to update the design-system library dependency, I don't know if version 2 is compatible, but between 1.0.0-beta.80 and 1.0.0-beta.99 is the change.

https://github.com/scaleflex/ui/blob/1.0.0-beta.80/packages/ui/src/core/button/button.component.tsx
https://github.com/scaleflex/ui/blob/1.0.0-beta.99/packages/ui/src/core/button/button.component.tsx

we need to change it in the package.json

https://github.com/scaleflex/filerobot-image-editor/blob/master/packages/react-filerobot-image-editor/package.json#L33

we were able to temporarily resolve the issue with:

"resolutions": {
  "**/@scaleflex/ui": "1.0.0-beta.90"
}

because we use yarn workspace...

BUT, these will still cause problems in other buttons, because the icon-button component of the design-system does not have the type el added in any version. 🤦🏻

then...., it is necessary to update the design-system so that any component that is rendered with an html button has type added.

this component needs to have type too.
https://github.com/scaleflex/ui/blob/master/packages/ui/src/core/icon-button/icon-button.component.tsx#L12

@AhmeeedMostafa AhmeeedMostafa added Waiting release The issue's code is added in the dev. branch but not yet released Released The issue is fixed/considered and released and removed Waiting release The issue's code is added in the dev. branch but not yet released labels Feb 10, 2023
@AhmeeedMostafa
Copy link
Collaborator

The issue is improved in version 4.3.8, please re-check it and let us know if all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released The issue is fixed/considered and released
Projects
None yet
Development

No branches or pull requests

3 participants