Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using data-image-list: crashes because of requestResizedImages() function #112

Closed
MarkoMZ opened this issue Dec 15, 2021 · 10 comments
Closed
Labels
bug Something isn't working

Comments

@MarkoMZ
Copy link

MarkoMZ commented Dec 15, 2021

when supplying a image list, when requestResizedImages() is called, the images do not have the right source!

my guess is that a function sets the image-src to the format '[base-url-of-website]/images-[idx].jpg', which should not be done!

@amrw-js amrw-js added the bug Something isn't working label Dec 21, 2021
@amrw-js
Copy link
Member

amrw-js commented Dec 21, 2021

hey @MarkoMZ, we are going to fix this issue in the next release.

@PedroVentura235
Copy link

Hi there, @amrw-js when will be the next release with this fix? thanks

@amrw-js
Copy link
Member

amrw-js commented Jan 25, 2022

hey @PedroVentura235, it should be this week

@amrw-js
Copy link
Member

amrw-js commented Jan 26, 2022

hey @PedroVentura235 , fixed on v2.7.2

@amrw-js amrw-js closed this as completed Jan 26, 2022
@PedroVentura235
Copy link

Hey, in my website id still didnt fix it, the error is the same : sets the image-src to the format '[base-url-of-website]/images-[idx].jpg'.
Website : https://bvansiao.pt/galerias/veiculos-combate/

@amrw-js
Copy link
Member

amrw-js commented Jan 27, 2022

hey @PedroVentura235,
please make sure that you are using data-image-list-x in the right way
if you are going to get the images from a server you have to refer to the folder that includes your images.
then use data-image-list-x in this way

   "iris-1.jpeg",
   "iris-4.jpeg",

Or you can remove data-folder by adding the images paths in this way so you don't need to add data-folder

   "https://scaleflex.airstore.io/demo/360-car/iris-12.jpeg",
   "https://scaleflex.airstore.io/demo/360-car/iris-15.jpeg"

but what I see on your website is that you are implementing the images in the wrong way
image

@PedroVentura235
Copy link

PedroVentura235 commented Jan 27, 2022

Hi @amrw-js , i am using the right way, i think .
In the previous version it worked, but those errors appears the same, and sometimes didnt work.
Because of the framework I am using I cant appoint directly to a folder, but i appoint directly path
image

@amrw-js
Copy link
Member

amrw-js commented Jan 27, 2022

@PedroVentura235 you have to replace data-image-list with data-image-list-x as it was deprecated from the previous version.
tested on my side it works

<div
             class="cloudimage-360"
             data-image-list-x='["https://bvansiao.pt/media/0ucnfuif/rato_2.jpg"]'
             data-speed="50"
             data-responsive="scaleflex">
</div>

image

@PedroVentura235
Copy link

Didn´t notice that change. yes That was it ;-)
Nice work and thanks

@PedroVentura235
Copy link

Hi, does version 2.7.2 became offline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants