fix: parse phone as string

Closes #365
ScaleLeap · May 3, 2021 · fcc83cd · fcc83cd
1 parent 3a78306
commit fcc83cd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/http.ts b/src/http.ts
@@ -336,6 +336,8 @@ export const parseResponse = <T>(
           textNodeName: 'text',
           parseTrueNumberOnly: true,
           tagValueProcessor: (value) => decode(value),
+          // force to be parsed as string
+          stopNodes: ['Phone'],
         },
         true,
       )

diff --git a/test/unit/__fixtures__/orders_list_orders.xml b/test/unit/__fixtures__/orders_list_orders.xml
@@ -17,6 +17,7 @@
                   <PostalCode>98103</PostalCode>
                   <CountryCode>US</CountryCode>
                   <AddressType>Commercial</AddressType>
+                  <Phone>3333333333</Phone>
               </ShippingAddress>
               <OrderTotal>
                   <CurrencyCode>USD</CurrencyCode>
@@ -106,7 +107,7 @@
                   <AddressLine1>1-2-10 Akasaka</AddressLine1>
                   <City>Tokyo</City>
                   <PostalCode>107-0053</PostalCode>
-                  <CountryCode>JP</CountryCode>                  
+                  <CountryCode>JP</CountryCode>
               </ShippingAddress>
               <OrderTotal>
                   <CurrencyCode>JPY</CurrencyCode>

diff --git a/test/unit/__snapshots__/orders.test.ts.snap b/test/unit/__snapshots__/orders.test.ts.snap
@@ -200,6 +200,7 @@ Array [
           "City": "Seattle",
           "CountryCode": "US",
           "Name": "Buyer name",
+          "Phone": "3333333333",
           "PostalCode": "98103",
         },
       },