Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce custom baseimage override #64

Closed
wants to merge 1 commit into from

Conversation

morganekmefjord
Copy link
Member

@morganekmefjord morganekmefjord commented Oct 10, 2020

To streamline better test projects In this suggested commit there are a new structure to allow for overriding of parameters.

version: '3.7'
services:
  client:
    build:
      context: .
      dockerfile: components/client/Dockerfile
      args:
        baseimage: "tensorflow/tensorflow:latest"

Illustrated by an example

docker-compose -f docker-compose.yaml -f reducer.yaml -f combiner.yaml -f client.yaml **-f tensorflow.yaml** --build --scale client=5

where tensorflow.yaml in this example is overriding the BASEIMAGE variable to the Dockerimage and instructs which base image to initiate the client image from.

In this sense the tests we construct can have the same basic structure but depending on framework selected can inherit base image from for example tensorflow to ensure the execution context is present.

@ahellander
Copy link
Member

Looks good but you accidentally made the PR to master...

@morganekmefjord morganekmefjord changed the base branch from master to develop October 12, 2020 16:26
@morganekmefjord
Copy link
Member Author

Looks good but you accidentally made the PR to master...

Changed base to develop..

@morganekmefjord
Copy link
Member Author

@ahellander But what do you think of this as an alternative approach to handle underlaying framework dependencies?

@sztoor
Copy link
Member

sztoor commented Oct 12, 2020

If we want to support different versions of TensorFlow, I think it will be a good strategy. But it may introduce extra complexity in the framework.

@ahellander
Copy link
Member

Yes, I think this is a good idea. Also because we will need to link in a different environment depending on the helper class we are using (TF, Torch, Sklearn) also for the Combiners.

@morganekmefjord morganekmefjord marked this pull request as draft October 15, 2020 08:01
@dstoyanova dstoyanova deleted the introduce_custom_baseimage_override branch November 25, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants