Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checker that verify that no suspect http code are present in the cassettes #1111

Closed
remyleone opened this issue Feb 24, 2022 · 0 comments 路 Fixed by #1145
Closed

Add a checker that verify that no suspect http code are present in the cassettes #1111

remyleone opened this issue Feb 24, 2022 · 0 comments 路 Fixed by #1145
Projects
Milestone

Comments

@remyleone
Copy link
Member

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

$ ack "code: 409" .
scaleway/testdata/function-namespace-basic.cassette.yaml
37:    code: 409

scaleway/testdata/rdb-privilege-basic.cassette.yaml
4211:    code: 409
4275:    code: 409

scaleway/testdata/data-source-rdb-privilege-basic.cassette.yaml
3312:    code: 409

This code should not exist in a clean cassette just like an error 5XX.
We should have a checker that will verify for all cassettes that no unauthorized HTTP code are present

New or Affected Resource(s)

  • scaleway_XXXXX

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@remyleone remyleone added this to the v2.2.1 milestone Feb 24, 2022
@remyleone remyleone added this to To do in Main Mar 9, 2022
@Monitob Monitob self-assigned this Mar 15, 2022
@Monitob Monitob moved this from To do to In progress in Main Mar 15, 2022
@Monitob Monitob moved this from In progress to Review in progress in Main Mar 18, 2022
@Monitob Monitob linked a pull request Mar 25, 2022 that will close this issue
@Monitob Monitob removed their assignment Mar 25, 2022
@Monitob Monitob moved this from Review in progress to Reviewer approved in Main Mar 25, 2022
Main automation moved this from Reviewer approved to Done Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Main
Done
Development

Successfully merging a pull request may close this issue.

2 participants