Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy validation should return error for invalid Sid #130

Closed
rahulreddy opened this issue Aug 1, 2016 · 0 comments
Closed

Policy validation should return error for invalid Sid #130

rahulreddy opened this issue Aug 1, 2016 · 0 comments
Labels
bug

Comments

@rahulreddy
Copy link
Collaborator

Currently policies with Sid

{
    Version: '2012-10-17',
    Statement: [{
        Sid: 'S3  \' <> ',
        Effect: 'Allow',
        Action: 's3:*',
        Resource: 'arn:aws:s3:::*',
    }],
}

passes validation
@rahulreddy rahulreddy added the bug label Aug 1, 2016
rahulreddy added a commit that referenced this issue Aug 1, 2016
@rahulreddy
BF: update regex for policy Sid
d092732 
Regex was returning partial matches, so for invalid formats string
was not failing the match.

Fix #130
@rahulreddy rahulreddy mentioned this issue Aug 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahulreddy