New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query auth compat #151

Closed

LaurenSpiegel opened this issue Aug 31, 2016 · 0 comments

Contributor

LaurenSpiegel commented Aug 31, 2016

For v4, the query params are not being sorted correctly if there is a lowercase query param.
For v4, if a signed 'header' is actually a query param, the value is not being picked up.
For v2, if there is a date in the header, the header date is being used in the string to sign rather than the expires date.
For v2, if there are x-amz query params (like x-amz-acl), they are not being included in the canonicalizedAmzHeaders.

LaurenSpiegel mentioned this issue

Fix compat for query auth #150

Merged

rahulreddy closed this as completed in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment