Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace various metalk8s-* storageclass by a single metalk8s one #2742

Closed
alexandre-allard opened this issue Aug 14, 2020 · 1 comment · Fixed by #2760
Closed

Replace various metalk8s-* storageclass by a single metalk8s one #2742

alexandre-allard opened this issue Aug 14, 2020 · 1 comment · Fixed by #2760
Assignees
@alexandre-allard
Labels
complexity:easy Something that requires less than a day to fix

Comments

@alexandre-allard
Copy link
Contributor

Component: salt, addons, docs

Why this is needed:
Today we have 1 metalk8s-prometheus (prometheus & alertmanager) and 1 metalk8s-loki (loki & fluent-bit) storageclass, but it does not make sense as the storageclass name must not be used to define the purpose of it.
Moreover, these class are exactly the same, so there is no point of keeping both.

What should be done:
Replace metalk8s-prometheus and metalk8s-loki storageclass everywhere by a metalk8s one.

Implementation proposal (strongly recommended):
Should be updated in examples, docs and salt

Test plan:
Tests should still work.
@alexandre-allard alexandre-allard added the complexity:easy Something that requires less than a day to fix label Aug 14, 2020
@TeddyAndrieux
Copy link
Collaborator

NOTE: Right now in Loki chart you cannot provide any selector for volume so for the moment we consider all volume with storage class metalk8s-loki as Loki volume check this commit message 97cd2ff

@alexandre-allard alexandre-allard self-assigned this Aug 24, 2020
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
salt: replace metalk8s-prometheus storageclass
a205aa1 
We know use a single metalk8s storageclass
for all addons as it does not make sense in K8s
to select storage by storageclass name.
We use label selector to get the right PV.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
docs: update post-install doc with new metalk8s storageclass
e6a2b7a 
Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
examples: update PV example manifest storageclass
c4598de 
Use the new metalk8s storageclass instead of the
old metalk8s-prometheus one.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
tests: update tests with new metalk8s storageclass
4eb0a91 
Refs: #2742
@alexandre-allard alexandre-allard mentioned this issue Aug 24, 2020
Merged
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
salt: delete old metalk8s-prometheus storageclass
7936edb 
Delete during prometheus-operator post upgrade cleanup

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 24, 2020
@alexandre-allard
salt: delete old metalk8s-prometheus storageclass
6273e23 
Delete during prometheus-operator post upgrade

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
salt: replace metalk8s-prometheus storageclass
e943779 
We know use a single metalk8s storageclass
for all addons as it does not make sense in K8s
to select storage by storageclass name.
We use label selector to get the right PV.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
docs: update post-install doc with new metalk8s storageclass
9acf753 
Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
examples: update PV example manifest storageclass
7b8932b 
Use the new metalk8s storageclass instead of the
old metalk8s-prometheus one.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
tests: update tests with new metalk8s storageclass
b36a9d9 
Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
salt: delete old metalk8s-prometheus storageclass
13bc5a0 
Delete during prometheus-operator post upgrade

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
salt: use metalk8s storageclass
51ab3a2 
We now use a single metalk8s storageclass
instead of one per addon (e.g. metalk8s-loki).

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
charts: add support for selector in Loki pvc
21696cf 
This is needed as Loki chart only allow to
target a PV with its storageclass name and
we now use a single storageclass for all addons.

This change needs to be ported upstream so
we can still upgrade Loki chart.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
salt,charts: use PV label selector for Loki pods
bc6416f 
Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
example: update Loki PV example to use the new storageclass
a37ddac 
This also adds a label on the PV so that we can
now select the PV based on this label instead
of the storageclass name.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 25, 2020
@alexandre-allard
docs: update post-install doc with new metalk8s storageclass for Loki PV
67f865d 
Refs: #2742
@alexandre-allard alexandre-allard mentioned this issue Aug 25, 2020
Closed
alexandre-allard added a commit that referenced this issue Aug 26, 2020
@alexandre-allard
salt: use metalk8s storageclass
5cc88a6 
We now use a single metalk8s storageclass
instead of one per addon (e.g. metalk8s-loki).

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 26, 2020
@alexandre-allard
charts: add support for selector in Loki pvc
61e4b42 
This is needed as Loki chart only allow to
target a PV with its storageclass name and
we now use a single storageclass for all addons.

This change needs to be ported upstream so
we can still upgrade Loki chart.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 26, 2020
@alexandre-allard
salt,charts: use PV label selector for Loki pods
b3d545f 
Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 26, 2020
@alexandre-allard
example: update Loki PV example to use the new storageclass
1b751d3 
This also adds a label on the PV so that we can
now select the PV based on this label instead
of the storageclass name.

Refs: #2742
alexandre-allard added a commit that referenced this issue Aug 26, 2020
@alexandre-allard
docs: update post-install doc with new metalk8s storageclass for Loki PV
1f3783d 
Refs: #2742
@alexandre-allard alexandre-allard mentioned this issue Aug 26, 2020
Merged
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
salt: replace metalk8s-prometheus storageclass
0ebc79c 
We know use a single metalk8s storageclass
for all addons as it does not make sense in K8s
to select storage by storageclass name.
We use label selector to get the right PV.

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
docs: update post-install doc with new metalk8s storageclass
af77fca 
Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
examples: update PV example manifest storageclass
375d6f3 
Use the new metalk8s storageclass instead of the
old metalk8s-prometheus one.

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
tests: update tests with new metalk8s storageclass
e492d82 
Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
salt: delete old metalk8s-prometheus storageclass
c7a5218 
Delete during prometheus-operator post upgrade

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
salt: use metalk8s storageclass
f7f9c17 
We now use a single metalk8s storageclass
instead of one per addon (e.g. metalk8s-loki).

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
charts: add support for selector in Loki pvc
f31721a 
This is needed as Loki chart only allow to
target a PV with its storageclass name and
we now use a single storageclass for all addons.

This change needs to be ported upstream so
we can still upgrade Loki chart.

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
salt,charts: use PV label selector for Loki pods
2104952 
Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
example: update Loki PV example to use the new storageclass
83093a9 
This also adds a label on the PV so that we can
now select the PV based on this label instead
of the storageclass name.

Refs: #2742
ChengYanJin pushed a commit that referenced this issue Sep 3, 2020
@alexandre-allard @ChengYanJin
docs: update post-install doc with new metalk8s storageclass for Loki PV
3a8ebab 
Refs: #2742
@alexandre-allard alexandre-allard mentioned this issue Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandre-allard alexandre-allard

Labels
complexity:easy Something that requires less than a day to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace metalk8s-loki storageclass with metalk8s one scality/metalk8s
2 participants
@alexandre-allard @TeddyAndrieux