ft: ZENKO-404 lifecycle service account #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipyoo
previously approved these changes
May 24, 2018
tmacro
previously approved these changes
May 24, 2018
rachedbenmustapha
previously approved these changes
May 24, 2018
ironman-machine
dismissed stale reviews from philipyoo, tmacro, and rachedbenmustapha
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
previously approved these changes
May 25, 2018
bennettbuchanan
previously approved these changes
May 25, 2018
jonathan-gramain
force-pushed
the
ft/ZENKO-404-lifecycleServiceAccount
branch
from
2a57b95
to
72d10eb
Compare
ironman-machine
dismissed stale reviews from philipyoo and bennettbuchanan
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
rahulreddy
force-pushed
the
development/8.0
branch
from
a2bde36
to
a7905b8
Compare
jonathan-gramain
force-pushed
the
ft/ZENKO-404-lifecycleServiceAccount
branch
from
72d10eb
to
2f6ec4a
Compare
|
PR has been updated. Reviewers, please be cautious. |
rahulreddy
previously approved these changes
Jun 1, 2018
Add support for service account 'service-lifecycle' in addition to existing 'service-replication'. ACL checks are shunted in both cases, we may implement more fine-grained access control later.
jonathan-gramain
force-pushed
the
ft/ZENKO-404-lifecycleServiceAccount
branch
from
2f6ec4a
to
b627c32
Compare
ironman-machine
dismissed
rahulreddy’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
rahulreddy
approved these changes
Jun 1, 2018
|
Merging this for now as we seem to be having timeout/service issues with Azure Storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for service account 'service-lifecycle' in addition to
existing 'service-replication'. ACL checks are shunted in both cases,
we may implement more fine-grained access control later.