Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger for codemods #24

Merged
merged 1 commit into from Nov 2, 2018
Merged

Conversation

ssutar
Copy link
Contributor

@ssutar ssutar commented Oct 13, 2018

  • The logger will log the validation failures if any
  • Will have information like path, timestamp and status which can be used for debugging

- The logger will log the validation failures if any
- Will have information like path, timestamp and status which can be used for debugging
@pzuraq
Copy link
Collaborator

pzuraq commented Nov 2, 2018

Looks good for starters. I think the output will be difficult for users to parse since it's more of a traditional server log. It would be better to have output that is markdown and readable, I think the output of the ember-modules-codemod was a great example of this, it's a markdown file that's very easy for people to read and then follow up on.

@pzuraq pzuraq merged commit 5933c24 into ember-codemods:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants