Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #114

Closed
menagerie198 opened this issue Oct 22, 2022 · 14 comments
Closed

[BUG] #114

menagerie198 opened this issue Oct 22, 2022 · 14 comments

Comments

@menagerie198
Copy link

menagerie198 commented Oct 22, 2022

Problem description:

Since the latest (Omni) update, searching is not finding files I know to be there. It only seems to be finding files created since that update, and uncreated files. Is there a way of rebuilding the search index?

I am getting these errors in the Inspecor

errorLog.txt

Your environment:

  • Omnisearch version: 1.7.1

  • Obsidian version: 1.0.2

  • Operating system: Win 10

  • Number of notes in your vault (approx.): 3k

  • Other plugins that may be related to the issue:

@scambier
Copy link
Owner

The index is rebuilt at startup, so restarting Obsidian should do it. Is there any error message in the developer console (ctrl+shift+i)?

@menagerie198
Copy link
Author

Added error Log... errorLog.txt

@scambier
Copy link
Owner

I just published 1.7.2

This should hopefully show a Notice when the error triggers and stop the crashes (at the expense of some other things). Could you also tell me if you a see a message like this, a few seconds after startup?

Omnisearch - Indexed 1318 notes
Omnisearch - Timing: 11184.28076171875 ms

@wzajchow
Copy link

I have the same problem.
Additionally, 'Tab' switching between vault and file search works only in one direction (possible to switch from file search to vault search but not vice versa).
error_log.txt

@wzajchow
Copy link

wzajchow commented Oct 22, 2022

I just published 1.7.2

This should hopefully show a Notice when the error triggers and stop the crashes (at the expense of some other things). Could you also tell me if you a see a message like this, a few seconds after startup?

Omnisearch - Indexed 1318 notes
Omnisearch - Timing: 11184.28076171875 ms

After startup I am getting the notification saying: "Omnisearch - Error while getting tags from file, see developer console"
error_log_v172.txt

Edit: but the search is working again now! :)

@menagerie198
Copy link
Author

This is what I got...

'error while getting aliases from files. See developer console'

errorLog.txt

Search also appears to be working ok though.

@scambier
Copy link
Owner

That is one interesting bug :D

Could you try disabling all other plugins, and re-enabling them one by one? I suspect one of them is playing with metadata in a way that Omnisearch does not expect.

@wzajchow
Copy link

I disabled all other plugins, restarted Obsidian and I got the same error: "Omnisearch - Error while getting tags from file, see developer console"
error_log_v172_allDisabled.txt

@scambier
Copy link
Owner

Thank you, I'll fix that asap

@scambier
Copy link
Owner

Alright it should be fixed with 1.7.3

Obsidian slightly changed their API, but I don't understand why this bug didn't show up for me 🤔

@wzajchow
Copy link

wzajchow commented Oct 22, 2022

In 1.7.3 no more notification error and switching using TAB is working fine. Thanks for such a quick fix!

My suggestion is that when changing search file <->search vault, the searched phrase should stay in the search box and not be removed.

The use case is simple: I am looking for 'something' in my file. It doesn't exist so I press TAB to search for it in the whole vault. Now I must retype the phrase I am searching for.

@scambier
Copy link
Owner

My suggestion is that when changing search file <->search vault, the searched phrase should stay in the search box and not be removed.

Yep, regression bug. Will fix that one too 😅

@menagerie198
Copy link
Author

All good here, too :-)

@scambier
Copy link
Owner

My suggestion is that when changing search file <->search vault, the searched phrase should stay in the search box and not be removed.

Fixed and will be deployed for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants