Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScandiPWA returning 404 status code on page with search results #4287

Open
pysebb opened this issue Feb 13, 2022 · 1 comment · May be fixed by scandipwa/route717#17
Open

ScandiPWA returning 404 status code on page with search results #4287

pysebb opened this issue Feb 13, 2022 · 1 comment · May be fixed by scandipwa/route717#17
Assignees
@AleksandrsKondratjevs
Labels
Area: Search BE Core Status: Waiting Estimate Type: bug Reported bug of ScandiPWA
Milestone
5.4.0

Comments

@pysebb
Copy link

pysebb commented Feb 13, 2022 •
edited by carinadues

Description:
ScandiPWA returns 404 status on the search page as well as some other pages. For the search page, it loads the page and shows product results, but status code is 404. Please check the other pages too (CMS, PDP, PLP, My Account, My Orders, HP, Checkout, Billing Step, Cart page).

Expected behavior:
Returns 200 if there are any products. No 404 error is seen in dev console.

Screenshots, Video, Logs
image

To Reproduce:

  1. Turn on developer console
  2. Go to https://tech-demo.scandipwa.com/tech_storeview/search/apple
  3. 404 status is returned
  4. Browse through the other pages too

Versions:

  • ScandiPWA: 5.2.4
  • Magento 2.4.3

Additional context:
For all crawlers, google ads, facebook pixel, anything related to search page, search site is invisible since it returns 404.
@carinadues carinadues added this to the 5.2.6 milestone Feb 14, 2022
@carinadues
Copy link
Contributor

carinadues commented Feb 14, 2022 •
edited

Comment from Sebastian in Slack:

For anyone wanting a quick fix for this, add this line:
<item name="search" xsi:type="string">ScandiPWA\Router\Validator\AlwaysPass</item>
in
vendor/scandipwa/route717/src/etc/di.xml:25

@carinadues carinadues changed the title ScandiPWA returns 404 status code for Search Page ScandiPWA returning 404 status code Feb 16, 2022
@Elena-Evsa Elena-Evsa changed the title ScandiPWA returning 404 status code ScandiPWA returning 404 status code on page with search results Feb 17, 2022
@AleksandrsKondratjevs AleksandrsKondratjevs linked a pull request Mar 4, 2022 that will close this issue
Open
@carinadues carinadues modified the milestones: 5.2.7, 5.2.8 Mar 28, 2022
@carinadues carinadues added the BE label May 3, 2022
@carinadues carinadues modified the milestones: 5.2.8, 5.2.9 May 19, 2022
@carinadues carinadues modified the milestones: 5.3.1, 5.3.2 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AleksandrsKondratjevs AleksandrsKondratjevs

Labels
Area: Search BE Core Status: Waiting Estimate Type: bug Reported bug of ScandiPWA
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

issue-4287 - Add validation for some pages AleksandrsKondratjevs/route717
5 participants
@pysebb @AleksandrsKondratjevs @carinadues @Elena-Evsa @pablobentivengo