Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for deriving serde Serialize and Deserialize on generated structs. #32

Closed
slackers123 opened this issue Apr 9, 2023 · 1 comment · Fixed by #33
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@slackers123
Copy link
Contributor

Adding this would be helpful when trying to use the generated output of wgsl_to_wgpu as the types for a whole project.
I will try adding this in my own fork since it seems fairly simple.

Thank you for this amazing crate, and I hope my contribution is helpful.

@ScanMountGoat
Copy link
Owner

This could be a neat feature but should definitely be optional. You could add a derive_serde field to WriteOptions that defaults to false. This should be fairly simple to implement since a lot of the logic is already there for deriving bytemuck or encase.

@ScanMountGoat ScanMountGoat added enhancement New feature or request good first issue Good for newcomers labels Apr 9, 2023
@ScanMountGoat ScanMountGoat linked a pull request Apr 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants