Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has the availableRAM_GB option been removed or replaced? #15

Closed
cymatn opened this issue Jul 15, 2020 · 7 comments
Closed

Has the availableRAM_GB option been removed or replaced? #15

cymatn opened this issue Jul 15, 2020 · 7 comments

Comments

@cymatn
Copy link

cymatn commented Jul 15, 2020

Hi,

I recently updated to 2.2 from within EEGLAB, and 'availableRAM_GB' now gives the following error.

EG = clean_rawdata(EEG, -1, -1, -1, -1, 20, 0.25, 'availableRAM_GB', 8);
Error using clean_rawdata
Too many input arguments.

It seems to be because ARS_calibrate does not accept it as one possible input anymore. I was wondering if it has been replaced by some alternatives (or default value), or why this had been removed.

Thank you,
Cyrille

@arnodelorme
Copy link
Contributor

Dear Cyrille,

Which version were you using before? Probably a very old version. There were updates to clean_rawdata that had conflicts, so this option was removed because of that about a year ago. Who told you to use that option? Copying @MakotoMiyakoshi here.

Arno

@armenbagdasarov
Copy link

Hello! I have the same question as Cyrille.

" 'availableRAM_GB' is for clean_rawdata1.10. For any newer version, it will cause error. "

Using the same parameters, the final results from clean_rawdata() fluctuate after ASR. It is demonstrated that adding availableRAM_GB fixes this (in the link below), but now we can't use it if we are using the newer version of clean_rawdata?

https://sccn.ucsd.edu/wiki/Artifact_Subspace_Reconstruction_(ASR)

Is there any way fix to this? This is a huge problem for replicability. Any help would be much appreciated.

Thank you!
Armen

@arnodelorme
Copy link
Contributor

Could you try resetting the random seed before calling the function. Also better call cleanArtifact directly which has more options.

We will try to add back the option. @MakotoMiyakoshi maybe you could help?

@arnodelorme arnodelorme reopened this Jan 7, 2021
@MakotoMiyakoshi
Copy link

MakotoMiyakoshi commented Jan 7, 2021 via email

@arnodelorme
Copy link
Contributor

arnodelorme commented Jan 8, 2021 via email

@armenbagdasarov
Copy link

armenbagdasarov commented Jan 8, 2021

Thanks Arnaud! I believe this is working. But it's hard to tell because first I am removing bad channels using clean_rawdata and it is also giving me inconsistent results. I ran the same file 10 times through clean_rawdata. Sometimes it says there are 3 bad channels, sometimes 4, sometimes 5. Is there a similar fix that can deliver reproducible results for the other functions in clean_rawdata such as removing bad channels? And then I'm assuming this may be a problem for the additional removal of bad data periods function?

@arnodelorme
Copy link
Contributor

Now closing this report. I have added back availableRAM_GB but not 100% it works as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants