Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments by Makoto #26

Closed
arnodelorme opened this issue Jun 18, 2021 · 2 comments
Closed

Comments by Makoto #26

arnodelorme opened this issue Jun 18, 2021 · 2 comments

Comments

@arnodelorme
Copy link
Contributor

• The default max_mem is 64 (MB), but in asr_calibrate() it says 'The recommended value is at least 256.' Which is the recommended value?

We should change the recommended value to 64.

• In asr_calibrate, you use 2^21 to convert MB to Byte. But isn't it 2^20?

I copied the code from the asr_process.m. Looks like it should be 2^20 but Christian put 2^21. I think there is a reason for that (like when you type "df" on Linux you have to divide the memory block by 2 or something). @chkothe any idea?

• In the main GUI, 'Acceptable [min max] power range' is incorrect. In clean_windows line 105, sqrt is taken.

The function header also mentions power. I am confused @chkothe

• This is a reminder in case I forget it tomorrow--when we specify a large value (4096 MB for example) for the max_mem, the final result seems improved. We want to ask why to Christian tomorrow.

Good point.

@MakotoMiyakoshi
Copy link

  • Another point is that ASR uses matrix operation heavily. The input data must be full-ranked and double precision. It means typical average referencing and electrode interpolation should not be performed before applying ASR.

@arnodelorme
Copy link
Contributor Author

64Mb: changed header
Mb: left as is. There is a reason for it as you can read in asr_process. It is unclear why but better not change it.
Main GUI: changed text
Double precision: the functions already handle that apparently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants