Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes no clock offsets get recorded #8

Closed
tstenner opened this issue Oct 29, 2018 · 3 comments
Closed

sometimes no clock offsets get recorded #8

tstenner opened this issue Oct 29, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tstenner
Copy link
Collaborator

See https://github.com/sccn/labstreaminglayer/issues/338

@tstenner tstenner added the bug Something isn't working label Oct 29, 2018
@tstenner tstenner self-assigned this Oct 29, 2018
@tstenner
Copy link
Collaborator Author

tstenner commented Nov 3, 2018

Current status of the investigation: on at least one lab computer the inlet tried to connect to the data transfer port, which is the same as the clock synchronization port most of the time but not always.

@tstenner
Copy link
Collaborator Author

Closed in 5977990

@mgrivich
Copy link
Collaborator

In parallel, both Tristan and I diagnosed and corrected the bug, and there is a new release at https://github.com/sccn/liblsl/releases/tag/1.13-b2. You'll notice that release is beta. We are looking to do a bit more testing before making an official 1.13. I wrote the original bug. :/. I'm very sorry, considering how many people were impacted by this.

The bug was introduced in ff1e8e1a269d0848fdf1bbe98c8bc3ddf6d6f35b, 2017-07-13. While fixing an issue with ipv6 addresses, I accidentally set udp to look at the data_port rather than the service_port. Often these are the same, but sometimes they are not, which caused the udp port to fail intermittently. However, it could be reliably reproduced if you did the exact same action every time (in my case, opening the receive string before send string, and checking for timestamps on the receiver).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants