Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NScumm.Audio.Players should support stopping audio #7

Open
BenMcLean opened this issue Dec 5, 2020 · 1 comment
Open

NScumm.Audio.Players should support stopping audio #7

BenMcLean opened this issue Dec 5, 2020 · 1 comment

Comments

@BenMcLean
Copy link
Contributor

The way the NScumm.Audio.Players API currently works is that songs are assumed to be playing all the time. You can call Load again to change to another song but there's no option to stop playback. I recommend adding a Stop method to the API.

@BenMcLean
Copy link
Contributor Author

I suppose this isn't strictly necessary since outside code with access to the IOpl instance could achieve the same effect by manually sending a "mute" signal and refrain from calling Update() when music is supposed to be stopped, but it seems like implementing a stop function would be cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant