Enable allow_failures and fast_finish for 1.8 based Ruby versions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this yet :S We still try to keep ruby1.8 compatibility. Mostly because the gem was not working for 1.9 until last year. Let's wait a little longer, at least add some big features before stop the 1.8 support. |
|
It's 5 months later. ⌛ Any further thoughts? |
robertodecurnex
force-pushed
the
master
branch
2 times, most recently
from
3fc1c27
to
b224195
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 Ruby 1.8.7 has been deprecated since mid-2013. This change allows build failures for versions based on this Ruby branch. The question of maintaining support is outside the scope of this pull request.