IfDatabase("SqlServer") matches "SqlServerCE" database type

[stonkie]

When using the IfDatabase() method, "SqlServer" matches "SqlServerCE" and "SqlServer2000". It is impossible to execute an operation for SQLServer but not for SQLServerCE using the IfDatabase() method.

This is because the IfDatabaseExpressionRoot.DatabaseTypeApplies() method uses StartsWith() instead of Equals() to compare the database type names.

Is this "by design"?

[detoxhby]

The issue still exists and makes it impossible to distinguis between those database types.

The most awkward part is that SqlServerCe has tons of unsupported operations and throws exception, so its not even possible to silently ignore it.

The real problem lies here:

fluentmigrator/src/FluentMigrator.Runner/Processors/SqlServer/SqlServerProcessor.cs

Line 41 in f17dca3

get { return "SqlServer"; }

Every SqlServer up from 2005 will have this processor and would report only this to IfDatabase check.

Easy fixup would be to expose originally the used database provider for migrations to make decision based on that.

[fubar-coder]

Duplicate of #387.
Workaround in release 2.0.0 is to use IfDatabase with predicate.