Expose connection string in a migration. Closes #240 #414
Conversation
The connection string that is passed into the runner is now exposed as property in the MigrationBase class.
If no connection string is set in the RunnerContext and is instead loaded by ConfigStringManager then set the Connection property so that it is passed onto the MigrationRunner.
ghost
assigned 
|
@daniellee i'll merge this in this evening, our processor could just expose the connectionstring, so IProcessor contract could expose readonly connectionstring property. But for now i think this pull is fine, we can fine tune later ;) |
|
Then I might as well change it first. I started off doing that way and then changed my mind. |
|
@daniellee mmm, i agree but you where talking about casting which is not needed because processor knows which connectiontype it uses :P ( i thought you where talking about violating liskov substition principle) |
|
True, I'll fix it without casting by adding the connection string property to the processor interface instead. Thanks for the suggestion. |
|
@daniellee thanks for the fix ;) |
Expose conn string in MigrationBase which is fetched from the Processor class when MigrationRunner is executed and passed down to MigrationBase.
|
My first solution didn't feel right. This feels much better. What do you think of this @tommarien? |
|
@daniellee i'll pull it in but will change something important, returning Connectionstring property after opening connection will not retain password entered in connectionstring, or for sqlserver you should specify Persist Security info. I will change the code so that the connectionstring will always return string passed in constructor. See http://msdn.microsoft.com/en-us/library/system.data.sqlclient.sqlconnection.connectionstring.aspx for more details |
|
Thanks, didn't think of that. |
|
@daniellee Like i allready said thanks for the pull and for doing most of the work ;) |
The connection string that is passed into the runner is now exposed as a property in the MigrationBase class.
I need a bit of feedback on this. This works as long as the connection string is set on the RunnerContext. This happens with the three runners (console, Nant and MSBuild) but for those who go directly against the MigrationRunner class then it has to be set on the RunnerContext that is then passed into the ctor of MigrationRunner.
The other way to do it would be to fetch the connection string from the Processor class. This is always set otherwise it is impossible to execute against a database. The problem is that the code for this is a bit more complicated. The JetProcessor has an oledb connection whereas all the other processors have an IDBConnection and I'd have to cast the processor to GenericProcessorBase or to JetProcessor. So it's all a bit messy but it would be guaranteed to be the real connection string.
What do you think?