Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 6.0.2 tag for scheb/2fa-qr-code makes other libraries 6.0.2 uninstallable #148

Closed
weaverryan opened this issue Jun 8, 2022 · 3 comments
Labels

Comments

@weaverryan
Copy link
Contributor

Hi!

Bundle version: 6.0.1

Description

Hi! scheb/2fa-qr-code depends on "scheb/2fa-bundle": "self.version",. The latest tag of scheb/2fa-qr-code is 6.0.1, but scheb/2fa-bundle has a 6.0.2. This means that if you have the latest (6.0.1) of scheb/2fa-qr-code installed, you will NOT be able to install scheb/2fa-bundle 6.0.2 (it will max out at 6.0.1).

To Reproduce

composer require scheb/2fa-qr-code
composer outdated

You'll notice that scheb/2fa-bundle is installed at version 6.0.1.

Additional Context

My guess is that scheb/2fa-qr-code does not have a 6.0.2 tag... since it had no changes. That's a great practice, but it causes this minor issue :). The only solutions I can think of are:

  • Tag packages even with no changes
  • Change self.version to something like ^6.0, though this adds some complexity as a maintainer, as it's possible for someone to mix (for example) 6.0 of the bundle with 6.1 of some other library.

Thanks for the excellent library - first problem I've ever found and it's so small :).

@weaverryan weaverryan added the Bug label Jun 8, 2022
@scheb
Copy link
Owner

scheb commented Jun 8, 2022

Wired, there shouldn't be a version 6 at all for that sub-package, since it has been discontinued since version 6 and there is no longer and code for it in the 6.x branch.

But somehow the version splitter is propagating the tags to the sub-package. Need to investigate why that is happening.

For now, please don't use v6 releases of scheb/2fa-qr-code.

@weaverryan
Copy link
Contributor Author

weaverryan commented Jun 8, 2022

Ah, that's right! I THOUGHT that package was gone... but then when I saw it, I assumed I had mixed things up in my head. Thanks :)

@scheb
Copy link
Owner

scheb commented Jun 11, 2022

I believe I've found it. The 5.x branch, which is still splitting off scheb/2fa-qr-code, was configured to propagade 6.* tags as well. Thanks for letting my know about that quirk.

@scheb scheb closed this as completed Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants