Increase performance by using CacheableVoterInterface

[kevinpapst]

Description

Symfony 5.4 introduced cacheable Voters, which speed up apps, which use a lot of is_granted calls.
You can define which attributes the Voter supports, and thus it will not be called for other attributes.

• https://symfony.com/blog/new-in-symfony-5-4-faster-security-voters
• https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/Security/Core/Authorization/Voter/CacheableVoterInterface.php

In one of my apps, I opened the profiler for a listing page, which triggers around 1000 is_granted calls.
Each of them calls Scheb\TwoFactorBundle\Security\Authorization\Voter\TwoFactorInProgressVoter in addition to the specific app Voter, see this example screenshot:

By changing the voter to this

class TwoFactorInProgressVoter implements CacheableVoterInterface
{

    public function supportsAttribute(string $attribute): bool
    {
        return $attribute === self::IS_AUTHENTICATED_2FA_IN_PROGRESS || $attribute === AuthenticatedVoter::PUBLIC_ACCESS;
    }

    public function supportsType(string $subjectType): bool
    {
        return $subjectType === 'null';
    }

    ... 
}

I was able to remove the Voter from almost all of the 1k is_granted decisions:

Which reduced the time from this:

to this:

A pretty low hanging fruit, which I'd like to address in a PR if that's okay!?
Or is there anything I am missing?

[scheb]

Sounds reasonable, give it a shot 👍

[kevinpapst]

Thanks @scheb - added PR #228