Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve an error on malformed path templates #1372

Closed
Stranger6667 opened this issue Jan 15, 2022 · 0 comments · Fixed by #1440
Closed

Improve an error on malformed path templates #1372

Stranger6667 opened this issue Jan 15, 2022 · 0 comments · Fixed by #1440
Labels
Difficulty: Beginner Ideal for newcomers Priority: Low Cosmetic or low-impact changes

Comments

@Stranger6667
Copy link
Member

Now a path like /foo}/ will cause a ValueError and halt the execution with something like this:

ValueError: Single '}' encountered in format string

It could be a better message that contains the full string + it shouldn't halt test execution

Steps:

  • Create a new MalformedPathTemplate error in exceptions.py
  • Catch ValueError in Case.formatted_path and reraise it as MalformedPathTemplate with a better message
  • Write a test for it
  • Add a changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Beginner Ideal for newcomers Priority: Low Cosmetic or low-impact changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Improve error message on malformed Open API path templates schemathesis/schemathesis
1 participant
@Stranger6667