Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send empty JSON object as body with GET requests #200

Closed
Stranger6667 opened this issue Oct 30, 2019 · 1 comment · Fixed by #202
Closed

Do not send empty JSON object as body with GET requests #200

Stranger6667 opened this issue Oct 30, 2019 · 1 comment · Fixed by #202
Assignees
Labels
Priority: Medium Planned for regular releases Type: Bug Errors or unexpected behavior

Comments

@Stranger6667
Copy link
Member

By default, schemathesis will generate an empty dictionary in Case arguments if there is nothing, but requests will serialize it to {} for body and will send with the requests. In some cases, it is possible to get 400, not from the application, but form some intermediate parties:

Your client has issued a malformed or illegal request

which is not what we want.
In general, it is not clear, what is needed - no body or empty JSON object as a body. It should be fixed

@Stranger6667 Stranger6667 added Priority: Medium Planned for regular releases Type: Bug Errors or unexpected behavior labels Oct 30, 2019
@Stranger6667 Stranger6667 self-assigned this Oct 30, 2019
@Stranger6667
Copy link
Member Author

In tests, we didn't check this and many tests use data generation from schemas with such issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Planned for regular releases Type: Bug Errors or unexpected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant