Need a --rpc-login option for monerod rpc

[Tomahna81]

It seems that the current implementation does not let the user run p2pool with a monerod rpc which has restricted access by password / login. Would be very useful (at least for me)...

[f-fusco]

Would be nice to have. Anyone following the official guide for connecting to a node over Tor can't use p2pool, unless by omitting the rpc-login option.

[adhisimon]

I am also waiting for this feature

[bladedoyle]

monero node rpc uses "digest" auth (as opposed to Basicauth)

[bladedoyle]

@SChernykh I think I can take this task and produce a PR if this is a feature you want added?

edit: Ya, it looks like this is more work than im prepared to take on. I am thinking it should be possible to write a simple shim/proxy to sit between the p2pool and the monero daemon that handles the digest auth....but built-in support would be much, much better and its June already so I'll wait on your work.

edit: I think instead I'll put a little time into writing a "./configure" script for interactive customization of the docker-compose configs. Will submit PR for this in a week or so.

[SChernykh]

@bladedoyle This is not an easy task. Just read through https://datatracker.ietf.org/doc/html/rfc7616 to get an idea. JSONRPCRequest class does requests at a very low level and uses external/src/llhttp to parse monerod responses. Implementing RFC 7616 is a lot of work, and bringing the whole libcurl just to enable rpc login seems an overkill. Also, in case with libcurl, it can't do HTTP requests in a fully non-blocking way, so additional workarounds (like uv queue_work) will be needed.

[SChernykh]

It looks like curl can work with libuv properly: https://curl.se/libcurl/c/multi-uv.html
This is still a huge task. I'll look into it in June.