Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load XML from Data in LayoutLoading protocol #161

Closed
wants to merge 2 commits into from
Closed

Load XML from Data in LayoutLoading protocol #161

wants to merge 2 commits into from

Conversation

cadrega
Copy link

@cadrega cadrega commented Nov 13, 2018

Add capabiilty to load XML from Data in LayoutLoading protocol

Add capabiilty to load XML from Data in LayoutLoading protocol
@nicklockwood
Copy link
Owner

@cadrega hi, sorry for the delay in reviewing this. It generally looks good, although I might tweak some of the method argument names for consistency. Also, there seems to be a problem with the Travis build.

@cadrega
Copy link
Author

cadrega commented Nov 20, 2018

@cadrega hi, sorry for the delay in reviewing this. It generally looks good, although I might tweak some of the method argument names for consistency. Also, there seems to be a problem with the Travis build.

Thanks @nicklockwood , of course you're welcome to fit this better to the Layout style.
I'm sorry about the Travis build errors! I don't nearly know how Travis works, but it seems that something has gone wrong with file encoding in my PR. The problem is on the first line of both changed files, at the (c) copyright character. What should I do now?

@cadrega
Copy link
Author

cadrega commented Sep 17, 2019

This pull request is still valid for the 0.6.38 version.
The only bad thing that happened are the first lines of each file showing a seemingly inexistent change, perhaps due to file encoding.
I looked at the Travis error logs, and it seems that the "error" it returns is actually a warning that I even see in Xcode 9.3.1. It's not related to any code that I introduced.

Upload directly the changed files in order to fix the encoding diff
@cadrega
Copy link
Author

cadrega commented Sep 17, 2019

I created a new pull request which should be cleaner than this one: new pull request

@cadrega cadrega closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants