Refactored Enum Init #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding the variable `identifiers`, this ensures that, when a new device type is added, the compiler will prompt the addition of the possible identifiers This also makes DeviceType more testable
|
Sorry, I don't have the time right now to do a proper review, but maybe someone else could jump in? |
|
@schickling - I've added some extra tests. All tests are passing. I'm good to go ahead and merge, just didn't want to reject any offers of a review. |
codytwinton
requested review from
RyanRamchandar
and removed request for
schickling
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the variable
identifiers, this ensures that, when a new device type is added, the compiler will prompt the addition of the possible identifiers. This also makes DeviceType more testable