Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psycopg2 is secretly required #63

Closed
DanCardin opened this issue Sep 13, 2019 · 0 comments · Fixed by #64
Closed

psycopg2 is secretly required #63

DanCardin opened this issue Sep 13, 2019 · 0 comments · Fixed by #64

Comments

@DanCardin
Copy link
Contributor

Describe the bug
depending on pytest-mock-resources requires you to also have psycopg2 in your environment. A previous PR (I think) removed the setup.py install requirement (because not every consumer will use pg); but we still perform imports of psycopg2 which cause those imports to fail.

Expected behavior
psycopg2 should remain an optional extra, but we should guard the imports such that it allows users to not have it installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant