Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redshift a "first-class" fixture #82

Closed
DanCardin opened this issue Mar 16, 2020 · 1 comment
Closed

Make redshift a "first-class" fixture #82

DanCardin opened this issue Mar 16, 2020 · 1 comment

Comments

@DanCardin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Today redshift just piggybacks off postgres's container definition to start its container.

This precludes us from making database-wide changes, like SET session_replication_role = 'replica'; which is a potential option for #62 and other specific kinds of tests.

If we used the same existing container startup mechanisms for redshift as we do for postgres, but left the host/port/user/pass the same; then PMR will think it has already been started. And then we'll either want to prefix the database name with "postgres/redshift" or ensure they're both using the same PMR-specific table for record-keeping on tests.

With that said, we'd have the same default behavior as today, but with the ability to theoretically configure the settings to be different for redshift and produce a different container.

@DanCardin
Copy link
Contributor Author

Closed by #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant