Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage transfer request #122

Open
RunyCalmera opened this issue Jun 16, 2023 · 5 comments · May be fixed by #267
Open

Percentage transfer request #122

RunyCalmera opened this issue Jun 16, 2023 · 5 comments · May be fixed by #267
Labels
enhancement New feature or request under development

Comments

@RunyCalmera
Copy link

RunyCalmera commented Jun 16, 2023

Would be great if you could see a percentage of the transfer. Now you see "Transferring..."
And you don't know the megabytes per second and how much you have to wait.

Transfering 1% completed. 2% etc till 100% would be great.

And showing the current transferring speed 8 mb per second upload/transfer would be awesome.

And 15 minutes remaining completion would be magic.

Giving first time users like me this info will increase the use. As I would know how much time it is going to take.

@schlagmichdoch schlagmichdoch added enhancement New feature or request to be decided labels Jun 23, 2023
@jacksongoode
Copy link

+1 for seeing a current transfer speed!

@schlagmichdoch
Copy link
Owner

@RunyCalmera @jacksongoode I'm currently implementing this but I'm unsure about the UI to keep it tidy and simple.

I think a percentage is redundant as the progress circle is quite obvious and looks clean.

I suggest 3 different messages:

  • "Sending..."
  • "1min 25s"
  • "20 Mbps"

I'd switching between these every 3s. Any thoughts?

Also, I'm not sure whether to show the transfer speed in Mbps or MB/s. MB/s might be easier to understand (10 MB file transferred with 10 MB/s takes 1s) while Mbps is commonly used in network and transfer contexts.

If someone uses an internet connection with 100 Mbps and does not know about the difference between Mbps and MB/s it might be confusing when PairDrop shows a smaller number than the speed of the internet connection.

@schlagmichdoch schlagmichdoch linked a pull request Feb 9, 2024 that will close this issue
42 tasks
@sbusch
Copy link

sbusch commented Feb 10, 2024

Just my 2 ct

I also think that progress would be redundant and just mess up the clean UI. That why I also like your idea of switching between those 3 messages, 3s seems fine to me.

You could start switching after a time longer than those 3s, to show the alternating texts only for longer transfers, for example after 5 or 10 seconds. That should also slightly improve accuracy of first shown predictions for ETA and transfer speed.

I'd vote for 10 MB/s (decimal system, not binary "MiB"), and would suggest other units, e.g. 50 kB/s (decimal system ⇾ lowercase k, not "KiB") for transfer speed < 1 MB/s which can easily happen on roaming scenarios. In a future settings menu you could offer options what info to show:

  • Speed (MB/s)
  • Bandwidth (Mbps)
  • ETA

P.S: thanks for this great project :-)

@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Feb 17, 2024

Thanks for your input @sbusch!

I'd vote for 10 MB/s (decimal system, not binary "MiB"), and would suggest other units, e.g. 50 kB/s (decimal system ⇾ lowercase k, not "KiB") for transfer speed < 1 MB/s which can easily happen on roaming scenarios.

I'm with you on that one. MiB is used for bandwidth only. This is about transfer speed so MB/s and kB/s it is.

In a future settings menu you could offer options what info to show:

  • Speed (MB/s)
  • Bandwidth (Mbps)
  • ETA

I'm not a fan of options as this adds complexity for the user but feel free to create an issue if you see it is needed in the future.

Finally, this is in a robust state to be tested: https://pairdrop-dev.onrender.com 🎉

I have increased the switching interval to 5s to make it easier to read. I would appreciate it, if you could test whether everything works as expected.

@schlagmichdoch
Copy link
Owner

As the repository was falsely flagged and hidden for the last month this probably never reached you so this is a friendly bump.

@sbusch I would appreciate it, if you could test this feature on the instance above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants