Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in UI when 2 device send files to another simultaneously #20

Closed
hoangnhatng opened this issue Feb 8, 2023 · 7 comments
Closed

Bug in UI when 2 device send files to another simultaneously #20

hoangnhatng opened this issue Feb 8, 2023 · 7 comments
Labels
bug Something isn't working UI/UX

Comments

@hoangnhatng
Copy link

"For example: A and B send requests to C simultaneously (both file and message requests). On C side, only one dialog box is displayed because the dialog box is too big and covers the middle of the screen, causing one request from the requesting device to be missed."

@schlagmichdoch
Copy link
Owner

What devices are you using? Could you provide some screenshots? What is the current behavior and how would you expect it to be?

@hoangnhatng
Copy link
Author

A send a Dog picture to C
A

B send a Cat picture to C
B1

In C just show dialog box to accept request from B, after accept it just download a Cat picture ( lost Dog picture send from A)
C1
C2

The solution maybe like sharedrop.io UI , they don't show review image and show dialog at avatar of the device.

solution

@schlagmichdoch schlagmichdoch added the bug Something isn't working label Feb 8, 2023
@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Feb 8, 2023

Thanks for the screenshots! I fixed this with d111bbf by putting requests in a queue. I think that is cleaner than a tooltip above the avatar. Can you test again?

@hoangnhatng
Copy link
Author

It's work great. I think you need same fixing with "message request".

@schlagmichdoch
Copy link
Owner

Currently it will just be overwritten by the newer message, correct? I‘ll look into it.

@schlagmichdoch
Copy link
Owner

Well I should have thought about that 🙄 Fixed by b0e798b. Could you test again?

@hoangnhatng
Copy link
Author

It's worl well. Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants