Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you consider a PR to switch to tool installers #4

Open
sandorfr opened this issue Jun 30, 2018 · 3 comments
Open

Would you consider a PR to switch to tool installers #4

sandorfr opened this issue Jun 30, 2018 · 3 comments

Comments

@sandorfr
Copy link
Contributor

Hi,

Would you consider accepting a PR switching from powershell to node engine. That would allow the extension to leverage tool installer APIs.

https://github.com/Microsoft/vsts-tasks/blob/master/docs/tools.md

Kind regards,
Cyprien

@sandorfr
Copy link
Contributor Author

Also please consider merging #3 and removing the [Preview] flag from the title. (the marketplace already shows a preview label because of the flags).

@helgejfo
Copy link
Collaborator

I would accept a PR changing to node. The preview flag was added to validate the current script for a while before removing it. I would like to keep the preview for the new solution as well, for a while at least to validate the changes.

@sandorfr
Copy link
Contributor Author

Yes my comment was not about the preview flag but the [preview] in the extension title. I think it's a bit redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants