Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to explicitly choose extension language #228

Open
schmich opened this issue Nov 16, 2018 · 3 comments · May be fixed by #349
Open

Allow user to explicitly choose extension language #228

schmich opened this issue Nov 16, 2018 · 3 comments · May be fixed by #349
Labels
hacktoberfest Digital Ocean Hacktoberfest

Comments

@schmich
Copy link
Owner

schmich commented Nov 16, 2018

  • Locale-specific messages are available to the extension (e.g. at chrome-extension://.../_locales/ja/messages.json)
  • We could statically store locale list and allow user to change it in settings
    • "Same as browser" setting (default) - no manual parsing/handling of messages
    • Changing language would require user to reload extension
  • Non-default locale
    • We manually locate and parse messages.json
    • Need to override chrome.i18n API or provide shim/proxy for extension to use

From @L1Q in #139:

I like how it's now conveniently translated in my case into russian, but I very much liked english.
Is there a way to force marinara to use english language again?

From Yoko in CWS:

This app is so convenient for me!
But from yesterday, its language had been transformed into Japanese.
Though I'm Japanese, I would like to use this app in English...
Sadly, it seems to be difficult (#139).
I will be happy to change its language freely :)

@omeganc
Copy link
Contributor

omeganc commented Jan 10, 2019

I have a similar issue with Chinese (with #139). IT dep had the chrome on my computer installed in chinese and i dont have the right to change it... the translation is kinda weird..? and the fact that its in a different language with my home PC is kinda bothering. i know its gonna be a lot of work tho. can help with the chinese if thats easier!

@schmich
Copy link
Owner Author

schmich commented Jan 10, 2019

@omeganc Thanks for the feedback. This is something I would like to fix, but the list of features is large and this is definitely a side project for me, so it might be a while.

I apologize if the translations are weird. Unfortunately, I only know English, so I have to rely on the translation skills of others. If you have the time, contributions and changes are welcome:

Also, I noticed you just joined GitHub, so if you need help navigating it or figuring something out, let me know. I'm happy to help where I can.

@omeganc
Copy link
Contributor

omeganc commented Jan 10, 2019

Thanks for the warm welcome. Im quite interested in the extension language issue here and thats why i opened an account actually. i promise i will take some time to think about it as well and hopefully help you with it. for now i hope my chinese changes will do....

@L1Q L1Q linked a pull request Oct 12, 2020 that will close this issue
@schmich schmich added the hacktoberfest Digital Ocean Hacktoberfest label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Digital Ocean Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants