Add commit description and ordering to output #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some problems to the old formatting of the library comparison
output. The x faster and % faster were confusing because it wasn't clear
how they were derived. Also it was not clear which commit SHA belonged
to which values.
In this updated value we give the formulas for the values that are being
shown as well. The latest commit is always first and the value will show
either SLOWER or FASTER based on actual values. Finally we're including
the git first line description to make it clearer which commit is which.
New output looks like this:
```
❤️ ❤️ ❤️ (Statistically Significant) ❤️ ❤️ ❤️
[7b4d80cb37] "1.8x Faster Partial Caching - Faster Cache Keys" - (10.9711965 seconds)
FASTER by:
1.0870x [older/newer]
8.0026% [(older - newer) / older * 100]
[13d6aa3a7b] "Merge pull request #36284 from kamipo/fix_eager_loading_with_string_joins" - (11.9255485 seconds)
P-value: 4.635595463712749e-05
Is significant? (P-value < 0.05): true
```
schneems
force-pushed
the
schneems/more-info-rails-bench
branch
from
f0d44b7
to
fced9e2
Compare
If you use a branch name with the method that is given i.e. "master" it can mess things up since "master" is the commit SHA you specify in the Gemfile.lock and not the actual master value (though this works correctly if you're specifying path: in your Gemfile). We can use SHA instead of BRANCHES for the input. Also just plain "library" instead of "library_branches"
schneems
force-pushed
the
schneems/more-info-rails-bench
branch
from
3bcf845
to
b3f5988
Compare
benoittgt
reviewed
Jun 28, 2019
| if significant? | ||
| io.puts "❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️" | ||
| io.puts "❤️ ❤️ ❤️ (Statistically Significant) ❤️ ❤️ ❤️" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems to the old formatting of the library comparison
output. The x faster and % faster were confusing because it wasn't clear
how they were derived. Also it was not clear which commit SHA belonged
to which values.
In this updated value we give the formulas for the values that are being
shown as well. The latest commit is always first and the value will show
either SLOWER or FASTER based on actual values. Finally we're including
the git first line description to make it clearer which commit is which.
New output looks like this: