Guard, and fix single sha perf:library tests #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should really clean up all these random SHA detection and shelling out scripts into a cleaner class. Would love to route stderr somewhere else like a log file and only show if things fail. Also would love to figure a way to make these git & shelling out commands faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using perf:library there was a bug that would result in the same sha being tested twice for instance if you ran:
Then it would incorrectly default to the same SHA. This PR fixes that behavior, it also detects this failure mode and raises an error if it happens somehow (perhaps the user accidentally puts it in twice somehow).
In addition there's a nice litte testing output that advertises which sha and description you're testing before you execute the tests: