Handle equal file size checks properly #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks! I did forget to actually divide the bytes 😅. Thanks for also introducing testing, once I fix the conflicts with the previous PR I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code wasn't working for file sizes like
1000,1000000, etc. because it was only doing less than and greater than checks, no equal checks.Also, for a file with size
1000001, it would show1000001MBwhich is not right, it was missing the needed divisions to turn bytes into megabytes and so on which I have added now.I also added some tests for the
Path::size_string_formatterfunction.Closes #1