Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpretable output in indirect relations vignette #11

Closed
corybrunson opened this issue Sep 18, 2022 · 1 comment
Closed

interpretable output in indirect relations vignette #11

corybrunson opened this issue Sep 18, 2022 · 1 comment

Comments

@corybrunson
Copy link

The vignettes in this package are, on the whole, exemplary. I appreciate that each addresses a specific topic so that none grow to impractical length.

The vignette "Indirect relations in networks" has an obvious limitation: A reader who is not executing code along the way cannot see or interpret the results. While too many matrices of indirect relations are calculated to all be printed, it would be helpful for one or two (e.g. for a predefined relation and for a custom relation adapted from it) to be printed and compared (element-wise subtraction or division? juxtaposed visualizations?).

This won't hold up my review, but i believe it would make this functionality more readily accessible. : )

Part of this JOSS review.

@schochastics
Copy link
Owner

Thanks for the suggestion! I'll put this on the list for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants