Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks don't zoom #389

Closed
erochest opened this issue May 16, 2016 · 1 comment
Closed

Clicks don't zoom #389

erochest opened this issue May 16, 2016 · 1 comment

Comments

@erochest
Copy link
Contributor

The problem is that clicking on an item in the public site ignores the current viewport default option unless the item is also a waypoint.

From @davidmcclure 's explanation in an email:

This is actually the intended behavior! Though, in retrospect, it was probably a mistake. The reasoning was this - there are times when automatically focusing the map in response to a click on the map can be disorienting. Eg, say there's a "point" record, with a really focused-in default zoom level. If the user is panning around at the level of the country, and clicks on a point, it can be confusing when the map instantly zoom really far down - the user has to manually zoom back, find their previous area of focus, reorient themselves, etc.

But, there are also lots of cases where you do in fact want this to happen, and I think they outnumber the cases where you don't. Unfortunately, this isn't configurable in the UI. But, changing this in the code would be very trivial - just this line would have to be removed:

https://github.com/scholarslab/Neatline/blob/master/views/shared/javascripts/src/map/map.controller.js#L80

@jeremyboggs
Copy link
Contributor

Close this, until we get more demand—with examples—to justify changing the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants