Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal pops up twice #5

Closed
erochest opened this issue Dec 9, 2015 · 2 comments
Closed

Modal pops up twice #5

erochest opened this issue Dec 9, 2015 · 2 comments

Comments

@erochest
Copy link
Collaborator

erochest commented Dec 9, 2015

No description provided.

@csbailey5t
Copy link
Contributor

This seems to be a result of 'done' being passed as a parameter here: https://github.com/scholarslab/chunk-corpus/blob/master/app/scripts/main.js#L216

With 'done' included, the map on L217 runs twice, causing the modal to open twice. In the second run, 'v' is an empty array. This is also the source of the overlay remaining after the modal technically closes, mentioned in #6. There, the overlay for the second trigger of the modal remains open.

Removing done from L216 seems to fix the issue, but I'm working to determine whether it breaks the app otherwise.

@csbailey5t
Copy link
Contributor

Fixed in 8720a39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants