Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag -save for the receiver to specify where to save the file #31

Closed
marcossegovia opened this issue Oct 21, 2017 · 5 comments
Closed

Comments

@marcossegovia
Copy link
Contributor

Current Behaviour
The path from the receiving file is the same as the received file, with no capability of changing the actual path for the current saving

Expected behavior:
When accepting the sending, it should prompt the for a a path where to store the received file (optionally?)

@schollz
Copy link
Owner

schollz commented Oct 21, 2017

@marcossegovia

You've found a bug (I made it #32)! When sending the file, it should only send the filename, not the file path! I will fix this.

The default behavior of the receiver should be to save the file in whatever directory is currently being run from. I think you are also suggesting a good feature - the ability for the receiver to specify where the file is saved. However I don't want this to be default because I want the receiver to do as little as possible by default. I can keep this issue up for this feature!

@schollz schollz added bug and removed bug labels Oct 21, 2017
@schollz schollz changed the title There is no chance to specify the path for the received file when store on the receiver Flag -save for the receiver to specify where to save the file Oct 21, 2017
@marcossegovia
Copy link
Contributor Author

Seems cool to me @schollz keep it up !

BTW nice repo idea, love it.

@threefjord
Copy link
Contributor

Can I do this one?

I'm assuming that with just ./croc -save it should query during the recieve, just after "ok? (y/n): ", but with ./croc -save <path> it should just use the provided path.

@schollz
Copy link
Owner

schollz commented Oct 21, 2017

@threefjord Sounds perfect. Its yours!

@threefjord
Copy link
Contributor

Woooo! Just made the PR ( #37 )

@schollz schollz closed this as completed Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants