Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new mne python module #193

Merged
merged 6 commits into from Apr 27, 2023

Conversation

Davi1990
Copy link

@Davi1990 Davi1990 commented Apr 14, 2023

Closes #187 (edit bu HTW to link PR to issue)

This is the initial pull request for adding the MNE-Python module to Brainhack-school

I wanted to thank you for taking the time to review my pull request.

I believe this could be a great opportunity for us to exchange ideas and improve the materials together

I appreciate any feedback or suggestions you may have

Thank you again, and I look forward to working with you.

Cheers

Dave

* Download the raw file at: https://drive.google.com/file/d/1-RSyaXp2Chx0zLuaAnlgK8o1VMo3enx8/view?usp=share_link

* Start a new jupyter notebook
* Watch the video and run the cells in the notebook
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Watch the video and run the cells in the notebook
* Watch the video and run the cells in the notebook

Comment on lines 70 to 74
How many channels do you have for each type of sensors?
What is the sampling frequency?
Have the data been filtered?
What is the frequency of the line noise?
Is there any bad channel?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block might not render correctly. Please build the page locally and double check.

Comment on lines 78 to 82
Read the file 'sub-s01_task-faceFO_eeg.fif' as an epoched object
Make a joint plot of the time-series?
Create a variable with the array of the evoked data
Decompose the data using SVD (use the function numpy.linalg.svd)
Make a matplotlib figure with 1 row and 5 columns and plot the first 5 components using the function mne.viz.plot_topomap
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block might not render correctly. Please build the page locally and double check.

Make a matplotlib figure with 1 row and 5 columns and plot the first 5 components using the function mne.viz.plot_topomap


* Follow up with Natasha Clarke to validate you completed the exercise correctly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to change the name...

Copy link
Collaborator

@clarkenj clarkenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clarkenj clarkenj dismissed htwangtw’s stale review April 27, 2023 19:09

Reviewed by Isil and Natasha

@clarkenj clarkenj merged commit 149f88b into school-brainhack:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an MNE-EEG module
4 participants