Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-on-drag while re-ordering columns #13

Closed
hsin421 opened this issue Jun 13, 2016 · 3 comments
Closed

scroll-on-drag while re-ordering columns #13

hsin421 opened this issue Jun 13, 2016 · 3 comments
Assignees

Comments

@hsin421
Copy link

hsin421 commented Jun 13, 2016

Thanks for sharing your folk.

We're also building the re-ordering of columns then we saw yours.

Just curious, have you implemented the "scroll-on-drag" when you are re-ordering more columns that will fit the current page? We having issues on how to simulate horizontal scroll externally. If you have any ideas, please do share!

Thanks again

@KamranAsif
Copy link
Contributor

Hmm this seems like a problem we will run into @wcjordan

We know the scrollLeft value for the grid, and we know the left offset + width of the column drag. We can detect if we hit the left or right edge and change the scrollLeft value appropriately.

@hsin421
Copy link
Author

hsin421 commented Jun 13, 2016

Thanks for your fast reply!

We found that it's hard to control scrolling with scrollLeft or scrollToColumn

let's compare notes once we have clearer handle on this

@KamranAsif KamranAsif self-assigned this Jun 21, 2016
@KamranAsif KamranAsif added this to the 0.6.6 milestone Jun 21, 2016
@wcjordan wcjordan modified the milestones: 0.6.7, 0.6.6 Jun 24, 2016
@KamranAsif
Copy link
Contributor

Hey,

I've merged this in but we have a couple more tasks until we release 0.6.7
Feel free to check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants